Skip to content

Fixed issues#686

Merged
lalalaurentiu merged 3 commits intopeviitor-ro:mainfrom
lalalaurentiu:main
Mar 26, 2026
Merged

Fixed issues#686
lalalaurentiu merged 3 commits intopeviitor-ro:mainfrom
lalalaurentiu:main

Conversation

@lalalaurentiu
Copy link
Copy Markdown
Collaborator

This pull request introduces several improvements and fixes across the test suite and multiple scraper scripts. The most significant changes are the introduction of salary fields to the validation and output, enhancements to job location extraction logic, and the removal of an obsolete test script. These updates improve data quality, ensure compliance with new requirements, and modernize several scrapers.

Test validation and schema updates:

  • Added support for optional salary fields (salary_min, salary_max, salary_currency) in the JSON schema validation for job data, and updated documentation accordingly. [1] [2]
  • Modified the handling of the remote field in validation to automatically lowercase all entries before checking allowed values.

Scraper enhancements and fixes:

  • sites/librabank.py: Added logic to extract salary information from job detail pages and include it in the output. Improved city/county extraction logic for more accurate location data. [1] [2]
  • sites/lseg.py: Refactored to use direct API requests instead of the custom Scraper class, improved location extraction (including fallback and normalization), and ensured each job has a remote field. [1] [2]
  • sites/magnaelectronics.py: Rewrote the scraper to use the Workday API, improved location extraction and normalization, and ensured the output includes a remote field.

Other changes:

  • sites/jacobsdouweegberts.py: Migrated from using the custom Scraper class to direct HTTP requests and BeautifulSoup, improved location normalization for Bucharest.
  • Removed the obsolete __test__/publish.py script.

…lectronics to enhance job data extraction, improve location handling, and streamline API requests
@lalalaurentiu lalalaurentiu merged commit 4fb4108 into peviitor-ro:main Mar 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant