Merged
Conversation
…s and update remote value handling
…lectronics to enhance job data extraction, improve location handling, and streamline API requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes across the test suite and multiple scraper scripts. The most significant changes are the introduction of salary fields to the validation and output, enhancements to job location extraction logic, and the removal of an obsolete test script. These updates improve data quality, ensure compliance with new requirements, and modernize several scrapers.
Test validation and schema updates:
salary_min,salary_max,salary_currency) in the JSON schema validation for job data, and updated documentation accordingly. [1] [2]remotefield in validation to automatically lowercase all entries before checking allowed values.Scraper enhancements and fixes:
sites/librabank.py: Added logic to extract salary information from job detail pages and include it in the output. Improved city/county extraction logic for more accurate location data. [1] [2]sites/lseg.py: Refactored to use direct API requests instead of the customScraperclass, improved location extraction (including fallback and normalization), and ensured each job has aremotefield. [1] [2]sites/magnaelectronics.py: Rewrote the scraper to use the Workday API, improved location extraction and normalization, and ensured the output includes aremotefield.Other changes:
sites/jacobsdouweegberts.py: Migrated from using the customScraperclass to direct HTTP requests and BeautifulSoup, improved location normalization for Bucharest.__test__/publish.pyscript.