forked from react-native-netinfo/react-native-netinfo
-
Notifications
You must be signed in to change notification settings - Fork 1
⏭️ Update Remediated Branch #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdougbrown
wants to merge
46
commits into
pexels:fix/android-release-issue-rn064-4
Choose a base branch
from
react-native-netinfo:master
base: fix/android-release-issue-rn064-4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
⏭️ Update Remediated Branch #2
sdougbrown
wants to merge
46
commits into
pexels:fix/android-release-issue-rn064-4
from
react-native-netinfo:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## [9.3.8](v9.3.7...v9.3.8) (2023-03-29) ### Bug Fixes * **windows:** fix crash in GetCellularGeneration for some LTE network adapters ([#660](#660)) ([7e1c7fb](7e1c7fb))
* fix: crash on devices without wifi Co-authored-by: Mike Hardy <github@mikehardy.net>
## [9.3.9](v9.3.8...v9.3.9) (2023-04-06) ### Bug Fixes * **android:** avoid crash on devices without wifi ([#662](#662)) ([a519e59](a519e59))
#666) Fix an issue causing an SSR exception if `getCurrentState` is called.
## [9.3.10](v9.3.9...v9.3.10) (2023-05-05) ### Bug Fixes * **web:** verify `window` exists before attempting to access navigator ([#666](#666)) ([60b99f2](60b99f2))
* fix: do not crash on android 11 * Also guard against crash here * Apply suggestions from code review --------- Co-authored-by: Mike Hardy <github@mikehardy.net>
## [9.3.11](v9.3.10...v9.3.11) (2023-06-29) ### Bug Fixes * do not crash on android 11 ([#672](#672)) ([bb13143](bb13143))
* feat(android): 🌟 add support for React Native 0.73 * leave package in AndroidManifest for rn < 71 compatibility --------- Co-authored-by: Peter Lazar <peter.lazar@limehome.de> Co-authored-by: Mike Hardy <github@mikehardy.net>
# [9.4.0](v9.3.11...v9.4.0) (2023-06-29) ### Features * **android:** add support for React Native 0.73 ([#675](#675)) ([224fdbb](224fdbb))
## [9.4.1](v9.4.0...v9.4.1) (2023-06-29) ### Bug Fixes * **android:** making rn >= 73 support also compatible with rn <= 66 ([#676](#676)) ([0c053eb](0c053eb))
… + NetInfoDisconnectedState (#680) * fix: added isWifiEnabled boolean for addeventlistener * fix: added isWifienabled boolean in disconnectedstate as well
## [9.4.2](v9.4.1...v9.4.2) (2023-11-01) ### Bug Fixes * **types:** add optional isWifiEnabled boolean to NetInfoUnknownState + NetInfoDisconnectedState ([#680](#680)) ([46c4c71](46c4c71))
# [9.5.0](v9.4.2...v9.5.0) (2023-11-01) ### Features * add optional reachabilityHeaders param to NetInfoConfiguration ([#673](#673)) ([0cbf067](0cbf067))
…cancel via AbortController (#678) * fix!: cancel _checkInternetReachability request on timeout & cancel Taken from #439 (comment) * style(lint): yarn validate:estlint --fix eslint behaves differently right now between windows/macOS and ubuntu the CI check is on ubuntu, and some problems are only showing up there * fix!: node v16 is now the minimum supported version - AbortController BREAKING CHANGE: netinfo now requires AbortController, node v16 / edge required it will likely not work on internet explorer from this version onwards
# [10.0.0](v9.5.0...v10.0.0) (2023-11-01) * fix(cancel)!: cancel _checkInternetReachability request on timeout & cancel via AbortController (#678) ([4bfd3e2](4bfd3e2)), closes [#678](#678) [/github.com//issues/439#issue-787487438](https://github.com//github.com/react-native-netinfo/react-native-netinfo/issues/439/issues/issue-787487438) ### BREAKING CHANGES * netinfo now requires AbortController, node v16 / edge required it will likely not work on internet explorer from this version onwards
* chore: migrate test apps to react-native-test-app And while we're at it, also bump react-native to 0.66. * build(deps): bump RNTA to current, react-native to current * fix(windows)!: increase windows minimum to 10.0.17763.0 for modern react-native-windows This was required as part of increasing the example app's react-native-windows dependency, it is still pretty old. If you need to support the previous react-native-windows minimum, please stay on an older version of the module --------- Co-authored-by: Mike Hardy <github@mikehardy.net>
…ompileSdk 33+ (#692) BREAKING CHANGE: - compileSdk minimum is now 33 - windows SDK minimum bumped to 10.0.17763.0 for current react-native-windows
# [11.0.0](v10.0.0...v11.0.0) (2023-11-04) * feat(android)!: specify export mode on BroadcastReceivers, requires compileSdk 33+ (#692) ([a5864cc](a5864cc)), closes [#692](#692) ### BREAKING CHANGES * - compileSdk minimum is now 33 - windows SDK minimum bumped to 10.0.17763.0 for current react-native-windows
## [11.0.1](v11.0.0...v11.0.1) (2023-11-07) ### Bug Fixes * **types:** fix type error on new headers feature ([#694](#694)) ([270be4f](270be4f))
…onfigs / events independently (#687)
# [11.1.0](v11.0.1...v11.1.0) (2023-11-08) ### Features * add useNetInfoInstance - a non singleton-state hook to manage configs / events independently ([#687](#687)) ([ca4c586](ca4c586))
InternetReachability aborts pending request by calling abort() of AbortController. According to AbortController API when abort() is called, the fetch() promise rejects with an Error of type DOMException, with name AbortError. So reject('canceled') will be ignored and checking error !== 'canceled' is useless.
The right way is to use abort('canceled') to set reject reason to 'canceled' instead of DOMException.
Previously because of that InternetReachability aborts previous request and calls _setIsInternetReachable(false).
## [11.1.1](v11.1.0...v11.1.1) (2023-11-29) ### Bug Fixes * internetReachability aborts handle cancel correctly ([#700](#700)) ([0a36296](0a36296))
Prevent using Network Information API at web applications for Tizen and WebOS
# [11.2.0](v11.1.1...v11.2.0) (2023-12-05) ### Features * **web:** add support for Tizen and WebOS ([#703](#703)) ([030887e](030887e))
## [11.2.1](v11.2.0...v11.2.1) (2023-12-12) ### Bug Fixes * update internetReachability fetch abort ([#706](#706)) ([d44d5a8](d44d5a8))
# [11.3.0](v11.2.1...v11.3.0) (2024-02-14) ### Features * add visionOS support ([#714](#714)) ([65ffc48](65ffc48))
## [11.3.1](v11.3.0...v11.3.1) (2024-02-27) ### Bug Fixes * update nativeInterface default export to support bridgeless mode ([#717](#717)) ([950410b](950410b))
## [11.3.2](v11.3.1...v11.3.2) (2024-05-11) ### Bug Fixes * **types:** isConnected / isInternetReachable should be boolean not true ([#721](#721)) ([6e2c422](6e2c422))
…roy delegates (#737) leaving the old method here so that old react-native versions will still work correctly, but it just delegates to the new method, which has the old implementation should have no effect on anyone except for fixing compile issues
## [11.3.3](v11.3.2...v11.3.3) (2024-09-12) ### Bug Fixes * **android:** add invalidate method for rn74+, onCatalystInstanceDestroy delegates ([#737](#737)) ([538623e](538623e))
# [11.4.0](v11.3.3...v11.4.0) (2024-09-12) ### Features * **android:** use node resolver to find react native package in monorepos ([#735](#735)) ([ef79980](ef79980))
…ct listener cleanup (#732) * fix: track ongoing requests during refresh * update example * add a request queue
## [11.4.1](v11.4.0...v11.4.1) (2024-09-20) ### Bug Fixes * ensure one reachability check in-flight at once / proper useEffect listener cleanup ([#732](#732)) ([eaed080](eaed080))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in master from the upstream source to keep us current and make fixes available to us.