Remove redundant while loop on sub app search#55
Open
laky55555 wants to merge 1 commit intopfalcon:masterfrom
Open
Remove redundant while loop on sub app search#55laky55555 wants to merge 1 commit intopfalcon:masterfrom
laky55555 wants to merge 1 commit intopfalcon:masterfrom
Conversation
Owner
|
So, I have to admit that patches like this point to the lack of testsuite in the project. Because well, it took me some 5 mins to remember that the idea was to support black-box functioning of mounted sub-apps, i.e. a user shouldn't be concerned if a webapp it mounts is itself consists of subapps, and thus subapp resolution should be done recursively. This is what the outer |
Currently while loop around sub app search is redundant and can be removed without any negative impacts on codebase.
laky55555
force-pushed
the
redundant_while
branch
from
ef1d285 to
6733ace
Compare
pfalcon
force-pushed
the
master
branch
2 times, most recently
from
e3acfcc to
dbc15e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like while loop around sub app search became redundant.
As far as I can see it won't change code if it is removed.