Skip to content

Catch exceptions in the only handling #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pietvr wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Catch exceptions in the only handling #7

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0bdde6a
Catch exeptions in the only handling
pietvr Oct 11, 2019
960ac15
Add raise exception after logging
pietvr Oct 14, 2019
2a320e7
Add quotes around 'only' and remove superfluous braces
pietvr Oct 25, 2019
3aff2e1
Use sphinx.util.logging.getLogger as suggested
pietvr Dec 23, 2019
4961e9e
Update sphinx_selective_exclude/eager_only.py
pietvr Sep 15, 2022
a0ba933
Update sphinx_selective_exclude/eager_only.py
pietvr Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions sphinx_selective_exclude/eager_only.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
#
import sphinx
from docutils.parsers.rst import directives
from sphinx.util import logging


logger = sphinx.util.logging.getLogger(__name__)


class EagerOnly(sphinx.directives.other.Only):
Expand All @@ -31,9 +35,13 @@ def run(self, *args):
env = self.state.document.settings.env
env.app.builder.tags.add('TRUE')
#print(repr(self.arguments[0]))
if not env.app.builder.tags.eval_condition(self.arguments[0]):
return []

try:
if not env.app.builder.tags.eval_condition(self.arguments[0]):
return []
except Exception as err:
logger.critical("Exception while evaluating 'only' directive expression: %r", err,
location=(self.env.docname, self.lineno))
raise err
# Otherwise, do the usual processing
nodes = super(EagerOnly, self).run()
if len(nodes) == 1:
Expand Down