Skip to content

Conversation

@Xharry01X
Copy link

I updated the packages that are used in ScPL, lots of error while running the test cases.

@pfgithub
Copy link
Owner

pfgithub commented Aug 29, 2024

I don't think all those tests should fail? It seems to be trying to parse @!ShouldEqual as part of the shortcut file which causes a parse error in all of them

If you're on windows, maybe git switched them to CRLF so they don't match? In testconfig/runtest.ts, this should fix it:

			const infilepath = path.join(dirname, infile);
			const contents = fs.readFileSync(infilepath, "utf-8");
-			const [shortcut, expected] = contents.split(
+			const [shortcut, expected] = contents.split("\r").join("").split(
				"\n\n@!ShouldEqual --------------------------------\n\n"
			);

@pfgithub
Copy link
Owner

It looks like .yarn/install-state is not supposed to be committed: https://yarnpkg.com/getting-started/qa. Since the project is still on yarn 1, the whole .yarn folder can be added to .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants