Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, Dave @dpage !
Hello, Andrew @adunstan !
Thanks for this very good FDW! I want to made this FDW better and introduce best industrial CI practice here.
This PR contains:
redis_fdw_hiredis_version()andredis_fdw_version()for debug and bugreports.test/local multiversional testswith README instructionMakefilebased on CI and common FDW samples such as SQLite FDW, InfluxDB FDW, Oracle FDW, Firebird FWD etc.CI process based on made by Toshiba corporation and used for SQLite FDW.
CI tests covers PostGIS and "no gis" test cases because Redis implements spatial functions and use WKT spatial format. Hence integration with PostGIS is not hard in future PRs.
Test set is equal for different PostgreSQL versions, but test output can be different. For example, there is no PostGIS support for PostgreSQL 18RC1.
I think this CI can allow speed up PR merging and backporting without any code problems. For example I am preparing encoding support PR and there is some other useful PRs like #41.