-
Notifications
You must be signed in to change notification settings - Fork 4
Add CI and CI scripts #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dpage
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is vastly overcomplicated, and doesn't prove the code actually works with the release packages that the majority of users will be running. Please just install the required packages directly in the workflow, and don't try to build anything except our own code from source.
This is against industrial standards, @dpage. What about FreeBSD, OpenSolaris and other CI workers where there is no |
As I showed in the pgAdmin example, we can test on different platforms. Just because we start with Debian or Ubuntu, that doesn't preclude us from later adding support for RPM based platforms, or others such as FreeBSD or OpenSolaris (for which we can build dependencies from source iif there is no other option).
That is incorrect. PGDG uses pre-packaged dependencies - for example, this is the script used to build the Debian CircleCI runners: https://github.com/anarazel/pg-vm-images/blob/main/scripts/linux_debian_install_deps.sh. On OpenBSD, pkg_add is used, and on Windows third party packages are downloaded and unpacked/installed as needed. Within the PostgreSQL buildfarm (buildfarm.postgresql.org), the individual machines are configured by their owners, and may or may not use pre-packaged dependencies. Most of them do, because the point is to test against the same builds a user is likely to have installed. The only code built as part of a PostgreSQL CI run (at least those managed by PGDG) is PostgreSQL itself. Similarly, in our case the only code we should build should be redis_fdw. |
Typical PG HBA for primitive CI
|
@dpage , C compilable complex CI was replaced to primitive CI against Ubuntu packages only. Is this enough? |
|
@dpage , Ubuntu repos doesn't have enough packages for our CI matrix Pg 14..18, please look at https://github.com/mkgrgis/redis_fdw/actions/runs/18239829804/job/51940049808 . Also, if I use PostgreSQL Global Development Group APT repo there are PosgreSQL packages but there are no PostGIS packages. Please look at https://github.com/mkgrgis/redis_fdw/actions/runs/18239180092/job/51938462779 . |
Add typical industrial multiversional CI based on SQLite FDW adopted for Redis FDW.
This PR should be merged after #45