ci test: use latest tag instead of version tag by otegami · Pull Request #74 · pgroonga/docker

otegami · 2025-10-02T23:31:56Z

Issue

The following error is raised when we want to test no-release images as follows.

  tag="${LATEST_VERSION}-debian-17"
  docker_image="groonga/pgroonga:${tag}"
  docker run \
    -d \
    -e POSTGRES_DB=pgroonga \
    -e POSTGRES_PASSWORD=${PGPASSWORD} \
    -e POSTGRES_USER=pgroonga \
    -p 127.0.0.1:5432:5432 \
    ${docker_image}
  shell: /usr/bin/bash -e {0}
  env:
    LATEST_VERSION: 4.0.4
    PGPASSWORD: pgroonga
Unable to find image 'groonga/pgroonga:4.0.4-debian-17' locally
docker: Error response from daemon: manifest for groonga/pgroonga:4.0.4-debian-17 not found: manifest unknown: manifest unknown

Run 'docker run --help' for more information
Error: Process completed with exit code 125.

ref: https://github.com/pgroonga/docker/actions/runs/18187593348/job/51775157123

Cause

The version specific tag (e.g., 4.0.4-debian-16)
doesn't exist until after release, but the latest tag is available when testing.

ref: https://github.com/pgroonga/docker/blob/main/.github/workflows/build.yml#L63-L76
ref: https://hub.docker.com/r/groonga/pgroonga/tags

Fix

We will use the latest tag instead of tag from this PR. And then, we can release the latest image even before releasing the new Docker image version.

## Issue The following error is raised when we want to test no-release images as follows. ``` tag="${LATEST_VERSION}-debian-17" docker_image="groonga/pgroonga:${tag}" docker run \ -d \ -e POSTGRES_DB=pgroonga \ -e POSTGRES_PASSWORD=${PGPASSWORD} \ -e POSTGRES_USER=pgroonga \ -p 127.0.0.1:5432:5432 \ ${docker_image} shell: /usr/bin/bash -e {0} env: LATEST_VERSION: 4.0.4 PGPASSWORD: pgroonga Unable to find image 'groonga/pgroonga:4.0.4-debian-17' locally docker: Error response from daemon: manifest for groonga/pgroonga:4.0.4-debian-17 not found: manifest unknown: manifest unknown Run 'docker run --help' for more information Error: Process completed with exit code 125. ``` ref: https://github.com/pgroonga/docker/actions/runs/18187593348/job/51775157123 ## Cause The version specific tag (e.g., 4.0.4-debian-16) doesn't exist until after release, but the latest tag is available when testing. ref: https://github.com/pgroonga/docker/blob/main/.github/workflows/build.yml#L63-L76 ## Fix We will use the latest tag instead of tag from this PR. And then, we can release the latest image even before releasing the new Docker image version.

komainu8 · 2025-10-03T00:29:46Z

Can we remove the "Detect the latest release" job?
Because we don't use LATEST_VERSION as docker images's tag by this modification.

kou · 2025-10-03T00:31:51Z

.github/workflows/test.yml

          PGPASSWORD: pgroonga
        run: |
-          tag="${LATEST_VERSION}-${{ matrix.id }}"
+          tag="latest-${{ matrix.id }}"


Can we detect PGroonga is released but Docker image release is forgotten by this?

I think we can detect this case at the build workflow because it uses the released Docker image.
If we added this change, we cannot check version specific tag (like 4.0.4-debian-17) after releasing it because its tag might be different from the latest one.
https://github.com/pgroonga/docker/blob/main/.github/workflows/build.yml

The build workflow does not execute periodically.
So, we don't detect Docker image release is forgotten probably.

build.ymlはcronで動いていないから関係ないんじゃない？

このワークフローはPGroongaをリリースしたけどDockerイメージはリリースし忘れていることを検出するために追加されました。
#18

たとえば、今は、PGroonga 4.0.4をリリースしたけど、4.0.4用のDockerイメージはリリースしていないですよね？そういうときにエラーになってDockerイメージのリリース忘れを気づけるという寸法です。このワークフローが定期実行されているのはそのためです。

docker/.github/workflows/test.yml

Lines 9 to 11 in df4ef88

schedule:

- cron: |

0 0 * * *

もし、ここで4.0.4-XXXタグじゃなくて常にlatest-XXXタグを使うと、4.0.4のDockerイメージをリリースしていないことを気づけなくなりますよね。それはこのワークフローをグリーンにするでしょうが、本来確認したかったことを確認できなくなっていませんか？

やるなら、scheduleのときは常に4.0.4-XXXで、push/pull_requestのときはlatest-XXXも許容するとかじゃない？

すみません。
次のように認識していて、完全に勘違いしていました。

pgroonga/dockerのリリースはしたが、対象のイメージをリリースできていないことを検知したい

そうではなくて確認したいのは、次である。

pgroonga/dockerをリリースできていないことを検知したい。

「pgroonga/dockerのリリース」と「対象のイメージをリリース」って何が違うの？

私はタグを打つことがpgroonga/dockerのリリースで、タグを打ったらDockerイメージもリリースされるようになっているので、違いがないように感じます。

はい。今は違いはない認識です。
私の読解力の問題で、「タグを打ったがDockerイメージがリリースされていない」のを検知したいのかなと捉えてしまっていました。

fix: d8142ec schedule実行のときは、"4.0.4-XXX"のイメージを確認し、
そうでないときは、"latest"をみるように変更してみました。

otegami · 2025-10-03T00:33:20Z

Can we remove the "Detect the latest release" job?
Because we don't use LATEST_VERSION as docker images's tag by this modification.

We still use it to check the PGroonga version at the last step.

docker/.github/workflows/test.yml

Line 97 in df4ef88

[ "${LATEST_VERSION}" = "${pgroonga_version}" ]

On scheduled runs (daily cron), use version-specific tag to verify the released version works correctly. On push/PR runs, use latest tag since the version-specific tag doesn't exist yet before release.

kou · 2025-10-03T08:03:56Z

.github/workflows/test.yml

          PGPASSWORD: pgroonga
        run: |
-          tag="${LATEST_VERSION}-${{ matrix.id }}"
+          if [ ${{ github.event_name }} = "schedule" ]; then


We should use environment variable as much possible to reduce evaluation timing:

Suggested change

if [ ${{ github.event_name }} = "schedule" ]; then

if [ ${GITHUB_EVENT_NAME} = "schedule" ]; then

fix: [2bcf376] (2bcf376) Thank you so much.
ref: https://docs.github.com/ja/actions/reference/workflows-and-actions/variables
ref: groonga/groonga#2277 (comment)

It's because we should keep the evaluation phase short and write minimal code.

otegami mentioned this pull request Oct 2, 2025

alpine: add support for PostgreSQL 18 #73

Merged

komainu8 approved these changes Oct 3, 2025

View reviewed changes

kou reviewed Oct 3, 2025

View reviewed changes

otegami force-pushed the ci-test-use-latest-tag branch from 608cfdc to 978bdc9 Compare October 3, 2025 02:22

ci test: use version tag on schedule, latest tag otherwise

d8142ec

On scheduled runs (daily cron), use version-specific tag to verify the released version works correctly. On push/PR runs, use latest tag since the version-specific tag doesn't exist yet before release.

otegami force-pushed the ci-test-use-latest-tag branch from 978bdc9 to d8142ec Compare October 3, 2025 02:23

kou reviewed Oct 3, 2025

View reviewed changes

use an environment variable

2bcf376

It's because we should keep the evaluation phase short and write minimal code.

kou merged commit 6429424 into pgroonga:main Oct 4, 2025
39 of 54 checks passed

otegami deleted the ci-test-use-latest-tag branch October 5, 2025 03:40

	if [ ${{ github.event_name }} = "schedule" ]; then
	if [ ${GITHUB_EVENT_NAME} = "schedule" ]; then

Conversation

otegami commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Cause

Fix

Uh oh!

komainu8 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

otegami commented Oct 3, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

otegami commented Oct 2, 2025 •

edited

Loading

komainu8 commented Oct 3, 2025 •

edited

Loading

otegami Oct 3, 2025 •

edited

Loading

otegami Oct 3, 2025 •

edited

Loading