Correct misspelling of 'Authenticate'#45
Open
Rychard wants to merge 2 commits intopgstath:masterfrom
Rychard:CorrectAuthenticate
Open
Correct misspelling of 'Authenticate'#45Rychard wants to merge 2 commits intopgstath:masterfrom Rychard:CorrectAuthenticate
Rychard wants to merge 2 commits intopgstath:masterfrom
Rychard:CorrectAuthenticate
Conversation
|
@pgstath how come this pull request has not gone in since dec 2016? Is this repository dead or is there a reason this pull request is not acceptable? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XmppClientcontains a method namedAutenticate, a misspelling ofAuthenticate.As altering the API surface of the class would break backwards-compatibility, I opted to decorate the existing method with
[Obsolete]instead of deleting it.Documentation was moved to the correctly-spelled method; the existing method is no longer documented.
Additionally, there was a single internal usage of the misspelled method, which I have updated.