Suggested modifications for srifreq #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed BASH_VERSINFO numbering; tidied; added safeguards; added some comments; added the ability to read ifcico reqmap for aliases; added trailing slash to PUB variable (for potential find symlink traversal); added comments regarding removal of special characters; added comment regarding possibly unnecessary path traversal removal for the RequestList and ResponseList
Author
|
Hello pgul! Please feel free to review the suggested changes for srifreq (and use whichever parts you would like). Most importantly this makes the script work with recent versions of bash (they appear to have changed the array contents of BASH_VERSINFO quite some time back in time). Best regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed BASH_VERSINFO numbering; tidied; added safeguards; added some comments; added the ability to read ifcico reqmap for aliases; added trailing slash to PUB variable (for potential find symlink traversal); added comments regarding removal of special characters; added comment regarding possibly unnecessary path traversal removal for the RequestList and ResponseList