Skip to content

Split runs by source name #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lchenay wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Split runs by source name #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9c5ad2
Split run by source name
lchenay Jul 18, 2013
aadc251
Fix inte
lchenay Jul 18, 2013
89e8d25
Fix comment in pull request
lchenay Jul 22, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions xhprof_lib/utils/xhprof_runs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,33 @@ public function save_run($xhprof_data, $type, $run_id = null) {

function list_runs() {
if (is_dir($this->dir)) {
echo "<hr/>Existing runs:\n<ul>\n";
echo "<hr/>Existing runs:<br />\n";
$files = glob("{$this->dir}/*.{$this->suffix}");
usort($files, create_function('$a,$b', 'return filemtime($b) - filemtime($a);'));

$sort_function = function($a, $b){
list($tmp,$source_a) = explode('.', basename($a));
list($tmp,$source_b) = explode('.', basename($b));

if ($source_a == $source_b) {
return filemtime($b) - filemtime($a);
}

return $source_a > $source_b;
};

usort($files, $sort_function);

$oldSource=null;

foreach ($files as $file) {
list($run,$source) = explode('.', basename($file));
if ($oldSource != $source) {
if (null !== $oldSource) {
echo "</ul><hr />\n";
}
echo "<b>$source</b><ul>";
$oldSource = $source;
}
echo '<li><a href="' . htmlentities($_SERVER['SCRIPT_NAME'])
. '?run=' . htmlentities($run) . '&source='
. htmlentities($source) . '">'
Expand Down