use existing manifest file#11
Open
Rich-Harris wants to merge 1 commit intophamann:masterfrom
Open
Conversation
phamann
approved these changes
Nov 28, 2017
phamann
requested changes
Nov 28, 2017
Owner
phamann
left a comment
phamann
left a comment
There was a problem hiding this comment.
Thanks for this @Rich-Harris, apologies for the delay. My only comment is we should update the readme to note this new behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the promised PR for #6. I didn't introduce a new option for it because I can't imagine there are occasions when you wouldn't want this behaviour, but let me know if you disagree and I'll update the PR.
It uses
JSON.parse(fs.readFileSync(...))rather thanrequire(...)— both in the source and the tests — becauserequirecauses stuff to get cached, which wreaks havoc in the tests when you requiretmp/manifest.jsonmore than once, as we are now.