Add bundle name placeholder#8
Open
notetiene wants to merge 1 commit intophamann:masterfrom
Open
Conversation
* src/index.js: Add `[name]` to be replaced to the bundle filename. * test/index.js: Add test to check `[name]` is replaced correctly.
phamann
requested changes
Aug 22, 2017
Owner
phamann
left a comment
phamann
left a comment
There was a problem hiding this comment.
@notetiene Thank you for submitting this PR and the improvement. Do you mind adding an example and description to the README.md file so that users know [name] is available.
Owner
|
@notetiene Are you still interested in this feature, or would you like me to take it over? Due to recent changes in master you now have some conflicts and the outstanding addition to the readme. Let me know either way as am happy to clean up in another branch. |
Author
|
@phamann Sadly, I'm not currently doing web development or using JS. We could probably close this issue since I don't see when/if I'll be able to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[name]to be replaced to the bundle filename.[name]is replaced correctly.