version-14: Refactoring for perfs and maintainability#169
Open
beingeek wants to merge 53 commits intoversion-14from
Open
version-14: Refactoring for perfs and maintainability#169beingeek wants to merge 53 commits intoversion-14from
beingeek wants to merge 53 commits intoversion-14from
Conversation
…kday.py refactor/2-move-utils.py-to-workday.py
…gs.py-to-workday.py Refactor/3 move-hr_addon_settings.py-to-workday.py
…inder-to-hr_addon_settings.py refactor/4-move-anniversary-reminder-to-hr_addon_settings.py
…-to-hr_addon_settings.py refactor/5-move-export_calendar-to-hr_addon_settings.py
…to-weekly_working_hours.py refactor/6-move-custom_scripts-to-weekly_working_hours.py
…ekly_working_hours refactor/7-move-list_view-to-weekly_working_hours
…eld_for_employee.py-patch-to-fixture refactor/8-change-add_custom_field_for_employee.py-patch-to-fixture
…-controller Refactor/12 refactoring workday controller
…lder-over-frappe.db.sql refactor/9-use-frappe.query_builder-over-frappe.db.sql
Refactor/21 workday normalization
fix: bug in workday employee_checkins col "employee_checkin"
…kday-generation-failure feature/25-notification-for-workday-generation-failure
… compensatory leave types
… checking no_break_hours and holiday condition
…ted to holiday checks as this scenrio covered in else case
…om weekly_working_hours and workday documents
Refactor/21 workday normalization
…ublisher and support email
…cripts for clarity
…_working_hours.js
Refactor/34 Cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gitlab issue: https://git.phamos.eu/phamos/hr-department/-/work_items/12
Mattermost Thread: https://chat.phamos.eu/team-philipp/pl/4y6smeomt7ryxfjjep1mkpqbba
This PR implements extensive refactoring and cleanup in the HR-Addon’s workday processing functionality for version-14. Inconsistent Implementation of Workday Record Handling, listed below are the PR's to refactor in order to reduce redundancy, code cleanup, improving consistency and performance.
The main objectives of this PR include:
Key Changes:
Workday & HR Settings Refactoring
Field & Schema Cleanup
workday.json) to simplify the schema.frappe.query_builderandfrappe.get_cached_value, leading to more efficient and maintainable queries.Eliminated redundant columns and associated calculations in the Weekly Working Hours module.
Enhanced Error Handling & Feedback
Related Pull Requests
workday.py.frappe.query_builder.