Skip to content

add summery of workday creation,skip dates for no weekly hours#214

Merged
sonalimandarnarkar merged 2 commits intosuncycle-version-15from
suncycle/suncycle#1906_version_15
Jan 15, 2026
Merged

add summery of workday creation,skip dates for no weekly hours#214
sonalimandarnarkar merged 2 commits intosuncycle-version-15from
suncycle/suncycle#1906_version_15

Conversation

@sonalimandarnarkar
Copy link
Copy Markdown
Contributor

@sonalimandarnarkar sonalimandarnarkar commented Jan 15, 2026

Parent : https://git.phamos.eu/suncycle/suncycle/-/issues/1906
Issue : https://git.phamos.eu/suncycle/suncycle/-/work_items/1920

This pull request enhances the handling and reporting of bulk workday creation in the HR module, especially for cases involving multiple employees and various workday statuses. The changes improve both backend processing and frontend feedback, providing clearer summaries of which workdays were created, skipped, or already existed, and the reasons for skipping.

Backend enhancements for bulk workday processing:

  • Added logic in get_unmarked_range to skip employees without weekly working hours, both for single and multiple employees, improving accuracy and preventing unnecessary processing. [1] [2]
  • Updated bulk_process_workdays to track and summarize workdays that were created, skipped (with reasons, e.g., "No Weekly Working Hours"), or already existed for each employee, using structured dictionaries for better reporting. [1] [2] [3]
  • Changed the collection of missing dates to a set for uniqueness and sorted the output for consistency. [1] [2]
  • The return value of bulk_process_workdays now includes detailed summaries for created, skipped, and existing workdays per employee.

Frontend improvements for user feedback:

  • Enhanced the list view JavaScript (workday_list.js) to display a detailed message summarizing created, skipped, and existing workdays by employee after processing, making it easier for users to understand the outcome of their bulk action.

@Kamalsingh1994 Kamalsingh1994 requested review from Kamalsingh1994 and removed request for Kamalsingh1994 January 15, 2026 11:11
@Kamalsingh1994
Copy link
Copy Markdown
Contributor

@copilot

Copy link
Copy Markdown

Copilot AI commented Jan 15, 2026

@Kamalsingh1994 I've opened a new pull request, #215, to work on those changes. Once the pull request is ready, I'll request review from you.

@sonalimandarnarkar sonalimandarnarkar merged commit e24dcac into suncycle-version-15 Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants