add summery of workday creation,skip dates for no weekly hours#214
Merged
sonalimandarnarkar merged 2 commits intosuncycle-version-15from Jan 15, 2026
Merged
Conversation
Contributor
|
@Kamalsingh1994 I've opened a new pull request, #215, to work on those changes. Once the pull request is ready, I'll request review from you. |
Kamalsingh1994
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent : https://git.phamos.eu/suncycle/suncycle/-/issues/1906
Issue : https://git.phamos.eu/suncycle/suncycle/-/work_items/1920
This pull request enhances the handling and reporting of bulk workday creation in the HR module, especially for cases involving multiple employees and various workday statuses. The changes improve both backend processing and frontend feedback, providing clearer summaries of which workdays were created, skipped, or already existed, and the reasons for skipping.
Backend enhancements for bulk workday processing:
get_unmarked_rangeto skip employees without weekly working hours, both for single and multiple employees, improving accuracy and preventing unnecessary processing. [1] [2]bulk_process_workdaysto track and summarize workdays that were created, skipped (with reasons, e.g., "No Weekly Working Hours"), or already existed for each employee, using structured dictionaries for better reporting. [1] [2] [3]bulk_process_workdaysnow includes detailed summaries for created, skipped, and existing workdays per employee.Frontend improvements for user feedback:
workday_list.js) to display a detailed message summarizing created, skipped, and existing workdays by employee after processing, making it easier for users to understand the outcome of their bulk action.