-
Notifications
You must be signed in to change notification settings - Fork 5
feat: create r script from settings file #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Gero1999
wants to merge
108
commits into
main
Choose a base branch
from
826-enhancement-create-r-script-from-settings-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: create r script from settings file #835
Gero1999
wants to merge
108
commits into
main
from
826-enhancement-create-r-script-from-settings-file
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atio calculations
apply relevant copilot suggestions Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Mateusz Kołomański <63905560+m-kolomanski@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…te derivation to pivot_wider_pknca_results.R (#467)
…rrent including on it the current_settings$general_exclusions
9 tasks
…erse/aNCA into 467-enhancement/r-script
Merge branch '467-enhancement/r-script' of https://github.com/pharmaverse/aNCA into 467-enhancement/r-script # Conflicts: # DESCRIPTION
…atio_calculations.R >> accept incoming) remote-tracking branch 'origin/467-enhancement/r-script' into 826-enhancement-create-r-script-from-settings-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #826
Description
This pull request introduces a new utility function for generating settings code from a template and makes a small bug fix in the ratio calculation logic.
Added a
default_mappinglist and a newget_settings_codefunction inR/get_session_code.Rto automate the generation of settings code from an RDS file, with an example invocation provided for demonstration.Updated
calculate_table_ratios_appinR/ratio_calculations.Rto ensureratio_tableis always treated as a data frame, preventing errors with NULL objects.Definition of Done
How to test
Use the function on a settings file and check that it works
Contributor checklist
Notes to reviewer
Better to review/merge first #789