Enhancement: Integrate settings upload in Data tab

[js3110]

Issue

Closes #719

Description

Updated data tab upload so that settings files can also be uploaded and read correctly, and then carried into the NCA tab.

Definition of Done

• Settings can be uploaded in data tab

How to test

Try uploading variations of datasets / settings etc to see what works and what doesn't work. If something doesn't work, it should give a clear error message to the user.

Contributor checklist

• Code passes lintr checks
• Code passes all unit tests
• New logic covered by unit tests
• New logic is documented
• App or package changes are reflected in NEWS
• Package version is incremented

Notes to reviewer

Anything that the reviewer should know before tacking the pull request?

[Shaakon35]

Hello @js3110

Thanks for the implementation, it looks good, just a few things to fix:

• Duplicate Rows Detected, this has to be done again, it's not kept in the settings
• buttons (in the exploration plots) and buttons (in the settings: choose NCA profile, etc.) are not kept when the settings are downloaded.
• The slope selector point exclusion is not kept

The pk parameters are working. (except when the NCA is not run)
I think we miss a general update of all the buttons and the parameters from the settings file, because when I open the settings file, I can see that I have all I changed inside.

[js3110]

Hello @js3110

Thanks for the implementation, it looks good, just a few things to fix:

• Duplicate Rows Detected, this has to be done again, it's not kept in the settings
• buttons (in the exploration plots) and buttons (in the settings: choose NCA profile, etc.) are not kept when the settings are downloaded.
• The slope selector point exclusion is not kept

The pk parameters are working. (except when the NCA is not run) I think we miss a general update of all the buttons and the parameters from the settings file, because when I open the settings file, I can see that I have all I changed inside.

Hi @Shaakon35 , the duplicate rows and exploration plot buttons are currently not in the settings, so these are not part of this PR. We can open separate issues to add these to settings (similar to #721 )

I will look into slope selection as this should be included.

What do you mean the PK parameters are working except when the NCA is not run?

[Shaakon35]

@js3110 The pk parameter selection works, sorry about that

[js3110]

@Shaakon35 I updated it, should be working with all the NCA settings now (setup, manual slopes, parameters). PTAL!

[Shaakon35]

@js3110
Thanks for the fix, I detected one last issue:

1. The slope selector settings is not applied.

[js3110]

merged to include exclusions, but not yet in settings upload processing. Opened new issue #898

[js3110]

thanks @m-kolomanski , I updated based on your comments. Although some become redundant again when we switch to yaml (#901 )
PTAL!

[Gero1999]

LGTM