closes #755 removing hardcoded DOSEA #908
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #755
Description
This PR removes hardcoded use of DOSEA in the PKNCA object creation workflow. The dose amount variable is now taken from the app’s column-mapping configuration (data$dose$columns$dose) and used consistently when building the PKNCAdose/PKNCAdata objects and any downstream joins/plots that rely on the dose column.
This keeps existing behavior for standard ADNCA inputs while enabling datasets where the dose amount column is not named DOSEA (e.g., DOSEAMT, EXDOSE), as long as the user maps the correct dose column in the app.
Change description.
Definition of Done
Remove hardcoding of DOSEA (dose amount) in the app workflow and underlying helpers.
Ensure the PKNCA dose variable is created using the mapped DOSE column name (from column mapping).
No functional change for existing workflows where the dose amount column is already DOSEA
Definition of done, preferably copied from the issue.
How to test
How to test features not covered by unit tests.
Contributor checklist
Notes to reviewer
Primary change is replacing direct "DOSEA" usage with the mapped dose column (data$dose$columns$dose) when constructing the PKNCAdose/PKNCAdata objects.
Downstream code already uses pknca_data$dose$columns$dose in places (e.g., joins), so once the PKNCA dose column is set correctly, the rest of the workflow should behave the same.
Backward compatibility is preserved for standard ADNCA inputs where the dose amount column is DOSEA.
Anything that the reviewer should know before tacking the pull request?