Skip to content

Conversation

@Gero1999
Copy link
Collaborator

@Gero1999 Gero1999 commented Jan 20, 2026

Issue

Closes #868

Description

  • Updated the tab_nca_server function to pass extra_group_vars into the NCA setup server module.
  • Enhanced the ratios_table_server function to join and use the extra grouping variables when determining ratio groups, improving flexibility in ratio calculations.

Definition of Done

  • ability to select additional grouping vars as ref/test parameters for ratios
  • ratios calculated correctly

How to test

Map data (with Other grouping variables as variables of interest) > NCA setup > Ratios Table > Choose the ratios to perform using variables > Check if results are the ones expected

Contributor checklist

  • Code passes lintr checks
  • Code passes all unit tests
  • New logic covered by unit tests --> Tests will be partially addressed in Closes #875 add tests for format data to reach 100 #909
  • New logic is documented
  • App or package changes are reflected in NEWS
  • Package version is incremented

@Gero1999 Gero1999 linked an issue Jan 20, 2026 that may be closed by this pull request
2 tasks
@Shaakon35 Shaakon35 requested review from Shaakon35 and js3110 January 20, 2026 13:35
Copy link
Collaborator

@Shaakon35 Shaakon35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@js3110
Copy link
Collaborator

js3110 commented Jan 20, 2026

@Gero1999 I am unable to calculate any ratios using the dummy data and additional grouping variables- everytime I get the message Error calculating NCA results: numbers of columns of arguments do not match

Is this supposed to happen? is there a way to test that the ratios are working?

@Gero1999 Gero1999 marked this pull request as draft January 21, 2026 07:00
@Gero1999 Gero1999 marked this pull request as ready for review January 21, 2026 15:26
@Gero1999 Gero1999 requested review from js3110 and removed request for js3110 January 21, 2026 15:27
Copy link
Collaborator

@js3110 js3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gero1999 Gero1999 merged commit c3f53b1 into main Jan 22, 2026
10 checks passed
@Gero1999 Gero1999 deleted the 868-feat/additional-grouping-variables-to-ratio-parameter-options branch January 22, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Add additional grouping variables to Ratio parameter options

4 participants