-
Notifications
You must be signed in to change notification settings - Fork 5
Allow additional grouping variables in the ratios table #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow additional grouping variables in the ratios table #911
Conversation
Shaakon35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@Gero1999 I am unable to calculate any ratios using the dummy data and additional grouping variables- everytime I get the message Is this supposed to happen? is there a way to test that the ratios are working? |
js3110
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue
Closes #868
Description
tab_nca_serverfunction to passextra_group_varsinto the NCA setup server module.ratios_table_serverfunction to join and use the extra grouping variables when determining ratio groups, improving flexibility in ratio calculations.Definition of Done
How to test
Map data (with
Other grouping variablesas variables of interest) > NCA setup > Ratios Table > Choose the ratios to perform using variables > Check if results are the ones expectedContributor checklist