Open
Conversation
Member
|
I disagree with the removal of |
Member
|
tag is because I'm waiting for the other side. |
Member
|
Since this PR is in discussion, I opened another one with a subset of the changes: #1821 The goal of this PR is to just remove the methods overriding methods from the pharo repository |
Member
|
so, we should now close this ? |
Member
|
Some things should still be integrated. But a decision needs to be taken for the #asValueHolder. I find it easier to us #asValueHolder personally as Esteban |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many extesions are:
This PR is a follow up of pharo-project/pharo#18501 that solves many unjustified extensions using the simple heuristics above:
WARNING⚠️ Depends on pharo-project/pharo#18501 and should be integrated after it