-
Notifications
You must be signed in to change notification settings - Fork 18
Lots of changes #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
computerdisciple
wants to merge
55
commits into
phate:master
Choose a base branch
from
computerdisciple:merge_pre_fork
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lots of changes #1369
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
6e592c9
Baby steps. Writing out some graphs.
computerdisciple 9e3600f
Implemented basic hashing.
computerdisciple 1a88f78
Rerouted hashes along gamme edges.
computerdisciple daeaa0a
Minor changes to coloring and added delims for sub-regions.
computerdisciple bad009f
Renamed some methods and fields to follow naming convention.
computerdisciple 19795ee
Merge branch 'pre'
computerdisciple 5d915a1
Refactored hash into a separate class for convenience.
computerdisciple 5e98e1d
Refactored hash into a separate class for convenience.
computerdisciple dfe5e4e
Save before delete flow draft
computerdisciple 8ac5ff9
Reactive data flows top down.
computerdisciple 7740b59
Added gamma end
computerdisciple cabe00c
Added theta node to flows
computerdisciple ea8e378
Added binary op hasher back in
computerdisciple 8ffe567
Added unary gvn op
computerdisciple 6ea5c1b
Removed flow data from cb args.
computerdisciple e46d6b4
Improved code layout.
computerdisciple d503107
Trivial changes
computerdisciple 048071e
Added call op
computerdisciple 07b96a2
Fixed bug in FlowData
computerdisciple 041b7df
Removed commented out code and added comments.
computerdisciple 9c192b0
Merge remote-tracking branch 'refs/remotes/origin/master'
computerdisciple ccca080
Compile check
computerdisciple c0c667a
Removed redundant loop.
computerdisciple 3e5d596
First draft with Theta gvn possibly working.
computerdisciple 637b702
Minor changes.
computerdisciple a177c99
Deleted some cout
computerdisciple 90b7f72
Refactoring making gvn computing gvn dependencies from output ptr
computerdisciple 83d47cf
New data flow style.
computerdisciple 9163d80
Clean build
computerdisciple 431bb37
Added leaf counting
computerdisciple c802a3d
Removed old code.
computerdisciple 7ed6f79
Clean build
computerdisciple b4f4bf2
Integrated new gvn manager
computerdisciple 51221f2
Changed visitors to methods.
computerdisciple 169cdf9
Save before code removal
computerdisciple fe4d91e
Some refactoring.
computerdisciple 065281b
Clean build
computerdisciple f164e31
Clean build
computerdisciple ca3314c
Theta gvn
computerdisciple 2644386
Theta gvn
computerdisciple aacd6d0
Fixed bug where local should have been field.
computerdisciple a6a9ae6
Found bug in arithmetic
computerdisciple 255c337
Working theta hash
computerdisciple a536bc5
Removed some debugging printing.
computerdisciple 38808ca
Cleaned up some code
computerdisciple 378d9a9
Checksum for inputs to prevent theta body reevaluation unless inputs …
computerdisciple b4dc2b7
Invariants treated as initial values when from outer loop.
computerdisciple 1d381da
Fixed minor bug.
computerdisciple 96efc34
Save before changes.
computerdisciple 93147c6
Added finalization pass for thetas'
computerdisciple 71969f5
Support for nested loops.
computerdisciple d6908fd
Merged.
computerdisciple fd5e59b
Factored out merging of values at loop entry.
computerdisciple 94f96e7
Fixed some issues
computerdisciple 3068e07
Trivial change
computerdisciple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,8 +39,13 @@ MemoryStateMergeOperation::NormalizeSingleOperand( | |
| const MemoryStateMergeOperation &, | ||
| const std::vector<rvsdg::Output *> & operands) | ||
| { | ||
| if (operands.size() == 1) | ||
| return operands; | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Warray-bounds" | ||
| #pragma GCC diagnostic ignored "-Wstringop-overflow" | ||
| if (operands.size() == 1){ | ||
| return {operands}; | ||
| } | ||
| #pragma GCC diagnostic pop | ||
|
|
||
| return std::nullopt; | ||
| } | ||
|
|
@@ -157,8 +162,13 @@ MemoryStateJoinOperation::NormalizeSingleOperand( | |
| const MemoryStateJoinOperation &, | ||
| const std::vector<rvsdg::Output *> & operands) | ||
| { | ||
| if (operands.size() == 1) | ||
| return operands; | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Warray-bounds" | ||
| #pragma GCC diagnostic ignored "-Wstringop-overflow" | ||
| if (operands.size() == 1){ | ||
| return {operands}; | ||
| } | ||
| #pragma GCC diagnostic pop | ||
|
Comment on lines
+165
to
+171
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Throw these pragmas out, please. |
||
|
|
||
| return std::nullopt; | ||
| } | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throw these pragmas out, please