This repository was archived by the owner on Jan 30, 2024. It is now read-only.
Fix captcha generation using rmagick4j 0.3.8. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it wouldn't work because some methods (sketch and destroy!) are still not implemented on rmagick4j. Besides that, calling the annotate method from an Magick::Image object would also raise an error. Instead, we can call it from a Magick::Draw object and the result is the same.
karlwilbur
added a commit
to K-and-R/easy_captcha
that referenced
this pull request
Nov 11, 2020
…svilela-pr-22 * matheusvilela/rmagick4jfix: Fix captcha generation using rmagick4j 0.3.8. Ref: phatworx#22
karlwilbur
added a commit
to K-and-R/easy_captcha
that referenced
this pull request
Nov 11, 2020
Ref: phatworx#22 By matheusvilela via Karl Wilbur (karlwilbur) * matheusvilela-pr-22: Fix captcha generation using rmagick4j 0.3.8.
TylerRick
pushed a commit
to TylerRick/easy_captcha
that referenced
this pull request
Jul 22, 2021
Rspec 3 - Merge conflicts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it wouldn't work because some methods (sketch and destroy!) are
still not implemented on rmagick4j. Besides that, calling the annotate method
from an Magick::Image object would also raise an error. Instead, we can call it
from a Magick::Draw object and the result is the same.
This fixes #14.