Live Preview fixes #2418
Live Preview fixes #2418
Conversation
devvaannsh
force-pushed
the
img-fix
branch
4 times, most recently
from
5800cb4 to
10a7d76
Compare
devvaannsh
force-pushed
the
img-fix
branch
2 times, most recently
from
8514512 to
813acd2
Compare
devvaannsh
force-pushed
the
img-fix
branch
2 times, most recently
from
c6a5cb8 to
5a47bbc
Compare
devvaannsh
force-pushed
the
img-fix
branch
3 times, most recently
from
c0eb2c1 to
527638e
Compare
… live preview scroll
…remains consistent
…y are properly visible
|
| "LIVE_DEV_IMAGE_GALLERY_SELECT_FROM_COMPUTER": "Select image from computer", | ||
| "LIVE_DEV_IMAGE_GALLERY_CHOOSE_FOLDER": "Choose download folder", | ||
| "LIVE_DEV_IMAGE_GALLERY_SELECT_DOWNLOAD_FOLDER": "Choose image download folder", | ||
| "LIVE_DEV_IMAGE_GALLERY_SEARCH_PLACEHOLDER": "Search images...", |
There was a problem hiding this comment.
Instead of ..., use unicode \u2026. That is the convention that we use in other places.
eg: "LIVE_DEV_OPEN_CHROME": "Open In Chrome\u2026"
| const currLiveDoc = LiveDevMultiBrowser.getCurrentLiveDoc(); | ||
| if (currLiveDoc && currLiveDoc.protocol && currLiveDoc.protocol.evaluate) { | ||
| currLiveDoc.protocol.evaluate("_LD.dismissImageRibbonGallery()"); | ||
| currLiveDoc.protocol.evaluate("_LD.dismissUIAndCleanupState()"); |
There was a problem hiding this comment.
closeLiveEditUI or some other better name for this?
| */ | ||
| function _downloadImageToPhoenixAssets(message, filename, extnName, phoenixAssetsDir) { | ||
| getUniqueFilename(phoenixAssetsDir.fullPath, filename, extnName).then((uniqueFilename) => { | ||
| function _showFolderSelectionDialog(message) { |
There was a problem hiding this comment.
- Show the top level dir contents first instead of just showing blank when dialog comes up
- not immediately needed, but note: move this as a
src/widgetsto a core component library. Given a div, the widget can render this ui. This is very reusable. Give optional support to for files as well- can reuse in ai panel for file additions.
| } | ||
|
|
||
| disableHoverListeners(); | ||
| _hoverLockTimer = setTimeout(() => { |
There was a problem hiding this comment.
Could this be the root cause of the issue we discussed earlier- ie, after clicking any item, the hover highlights wont come up for a brief time.
| ...updates, | ||
| expires: Date.now() + CACHE_EXPIRY_TIME | ||
| }; | ||
| window.localStorage.setItem('imageGalleryCache', JSON.stringify(newData)); |
There was a problem hiding this comment.
test behavior when local storage is full. will image gallery stop working? If local storage is full, then the image gallery will break?
raise a metrics with live preview localStorage Full so that we can observer this event happening.
| const allElements = document.querySelectorAll('[data-brackets-id]'); | ||
| allElements.forEach(el => el.setAttribute("draggable", false)); | ||
| this.element.setAttribute("draggable", true); | ||
| allElements.forEach(el => el.setAttribute("draggable", "false")); |
2 participants
No description provided.