This repository was archived by the owner on Dec 28, 2023. It is now read-only.
allow changing the VERSION constant#25
Open
nickshek wants to merge 3 commits intophilipbrown:masterfrom
nickshek:master
Open
allow changing the VERSION constant#25nickshek wants to merge 3 commits intophilipbrown:masterfrom nickshek:master
nickshek wants to merge 3 commits intophilipbrown:masterfrom
nickshek:master
Conversation
Owner
|
Why would you want to change the version number? The version number is supposed to track the version number of the package, and so IMO it would only get bumped when an update to the package is released. I'm curious to hear what your use case is? |
Author
|
Suppose we want to develop a API like this: If we want to use this package for developing this api,there will be two problems:
|
Owner
|
Why would you want to change the version number? The version number is used to ensure that both client and server are using the same version of the package. So the version number would only change when the package was updated. This version number has nothing to do with your API version number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows to overwrite the default version in http requests by subclassing. This can be useful to when the developer using this composer package want to control the version number.