Conversation
c746a78 to
41ffe11
Compare
41ffe11 to
0485830
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Raw connector tools make clients choose between low-level source-specific operations. This PR adds a small high-level context surface so clients can search and read allowed personal context without exposing every
raw connector tool.
What changed
search_personal_context.read_context_item.semanticToolsconfig.rawToolsEnabled: false.source_id,item_id, snippet, locator, and follow-up read action.How
The router now owns semantic tool registration and dispatch. It indexes raw connector tools by policy source ID, then chooses simple adapters for supported search/read tools such as Obsidian
search_notes/read_noteand filesystem-stylesearch_files/read_file.search_personal_contextdoes not attempt embedding search or global semantic ranking. It performs per-source keyword retrieval and returns aranking: "per_source_keyword_union"marker so the behavior isexplicit.
Changed files
src/server/router.ts- add semantic tool definitions, visibility checks, source adapters, keyword search, read-through behavior, and audit integration.src/cli/start.ts- passconfig.semanticToolsinto the router.tests/router.test.ts- cover semantic tool listing, search results, and read-through behavior with raw tools disabled.tests/server.test.ts- cover semantic tools through the HTTP MCP layer for a configured client.Verification