Fix revoke access token error handling#67
Merged
Anderson Valério (andersonvcv) merged 6 commits intopicsfrom Jun 2, 2025
Merged
Fix revoke access token error handling#67Anderson Valério (andersonvcv) merged 6 commits intopicsfrom
Anderson Valério (andersonvcv) merged 6 commits intopicsfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the error handling in the revoke access token flow by ensuring that failure to revoke does not disrupt the sign-out process while logging the error appropriately.
- Updated PicsRevokeAcessToken to return only an error instead of both response and error.
- Modified the backendLogout logic to adapt to the changed signature and handle error logging accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pics_oauthproxy.go | Updated PicsRevokeAcessToken to simplify error handling and response |
| oauthproxy.go | Updated usage of PicsRevokeAcessToken to match the new error-return behavior |
Comments suppressed due to low confidence (1)
pics_oauthproxy.go:38
- The function name 'PicsRevokeAcessToken' appears to have a typo in 'Acess'; consider renaming it to 'PicsRevokeAccessToken' for clarity.
func PicsRevokeAcessToken(backendRevokeURL string, accessToken string, clientID string, clientSecret string) (err error) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Eduardo Vozniak (evozniak)
requested changes
Jun 2, 2025
…s-forks/oauth2-proxy into anderson/fix-revoke-error
Eduardo Vozniak (evozniak)
approved these changes
Jun 2, 2025
Danilo Mendes Rocha (DaniloRochaGR7)
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Checklist: