Introduce ability for the system to parse JSON responses#108
Open
ecaron wants to merge 1 commit intophillro:masterfrom
ecaron:master
Open
Introduce ability for the system to parse JSON responses#108ecaron wants to merge 1 commit intophillro:masterfrom ecaron:master
ecaron wants to merge 1 commit intophillro:masterfrom
ecaron:master
Conversation
|
👍 |
1 similar comment
|
👍 |
Owner
|
I haven't dug into this, but Travis CI failed this pull request. If you can update such that it passes, ill merge. Also, if anyone wants to pickup maintaining this, Ill gladly add you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completing the suggestion offered in #35. This PR introduces a server option
parseJSONthat, when true (its false by default), will automatically parse all responses delivered by .on('data'... in elasticSearchCall.js.This PR has a straight-forward test coverage, a patch version bump, and a minor tweak in the README to reference the changes.