Added tests, fixed options handling in get(), deleteDocument()#84
Open
BryanDonovan wants to merge 7 commits intophillro:masterfrom
Open
Added tests, fixed options handling in get(), deleteDocument()#84BryanDonovan wants to merge 7 commits intophillro:masterfrom
BryanDonovan wants to merge 7 commits intophillro:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests, fixed options handling in get(), deleteDocument(), cleaned up spacing, did some linting.
There's a pending test in the core search canonical. That function only allows the options object to be passed in if no objName is passed in.