Skip to content

Apply pixelRatio scaling#7

Open
jhofmeyr wants to merge 4 commits intophilroberts:masterfrom
jhofmeyr:master
Open

Apply pixelRatio scaling#7
jhofmeyr wants to merge 4 commits intophilroberts:masterfrom
jhofmeyr:master

Conversation

@jhofmeyr
Copy link
Copy Markdown

@jhofmeyr jhofmeyr commented Apr 8, 2021

I created a fork to try things working with the new PoB file structure. In that regard, I ended up forking PoBMacOSBuild because it automates the process a bit. The recent changes to the Community PoB file structure meant a few extra steps to get everything in the right place.

Once the front-end was loading, the scaling was off. I managed to find some info on using devicePixelRatio to rescale output for retina displays. This seems to work well for me locally, although the font size seems a little off in some areas.

I don't know any of the underlying tech (QT / OpenGL / c or lua), so I'm sure this can be greatly improved 🙏

@philroberts
Copy link
Copy Markdown
Owner

Hmm, I'm not able to test this so I'm hesitant to merge it. I see there are a couple of attempts to handle this in another fork:

aspel@f34dfe8 which looks quite similar to your changes, and
aspel@6f04517 reverting that and disabling hidpi?

@jhofmeyr
Copy link
Copy Markdown
Author

Hmm, I'm not able to test this so I'm hesitant to merge it. I see there are a couple of attempts to handle this in another fork:

aspel@f34dfe8 which looks quite similar to your changes, and
aspel@6f04517 reverting that and disabling hidpi?

Ok - I'll try out that fork to see whether it work for me thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants