Open
Conversation
Owner
|
Hmm, I'm not able to test this so I'm hesitant to merge it. I see there are a couple of attempts to handle this in another fork: aspel@f34dfe8 which looks quite similar to your changes, and |
Author
Ok - I'll try out that fork to see whether it work for me thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a fork to try things working with the new PoB file structure. In that regard, I ended up forking PoBMacOSBuild because it automates the process a bit. The recent changes to the Community PoB file structure meant a few extra steps to get everything in the right place.
Once the front-end was loading, the scaling was off. I managed to find some info on using
devicePixelRatioto rescale output for retina displays. This seems to work well for me locally, although the font size seems a little off in some areas.I don't know any of the underlying tech (QT / OpenGL / c or lua), so I'm sure this can be greatly improved 🙏