Conversation
… module, but add all public symbols
|
Thanks for this attempt to tackle the package import conundrum. Before we go into the technical details, please rebase this work on top of the current master with #2 merged now to make the diff more manageable. Furthermore, please run flake8 on your code. It will complain about a few formatting choices. For convenience, I updated the Finally, the non capitalized command line descriptions are on purpose to be in line with the builtin entries created by |
…into change_import
|
Rebased onto the master branch. |
|
Got EXtra-metro working with a minor name and argument change related to the Could you please revert the various style changes not relevant for the functionality change? This will also make the diff clearer. |
…nitialization routine back to 'init'
|
I reverted the style changes and fixed some minor importing issue. |
philsmt
left a comment
There was a problem hiding this comment.
As you may have noticed, we've been working on getting metro-sci compatible with modern versions of Python and Qt in fix/forward-compat. This is fairly critical for us to continue supporting it on modern hardware.
I'd love to get this done finally and most of the testing on it already. As its history is unfortunately a bit wonky by mergers of masters into it, I did not manage to rebase it. while merging into it seems to work. I would ask you to squeeze the commits please to get rid of the duplicate commits.
| self.destroyed.connect(_on_device_destroyed) | ||
|
|
||
| # for correct/full initialization set as visible first | ||
| self.setVisible(True) |
There was a problem hiding this comment.
What specific problem does this solve? It seems not ideal to potentially pop up a window briefly, just to hide it immediately.
Cleaner initialization of the metro module