Skip to content

Enable retrieving and overriding wind attack angle#114

Open
ai-qui wants to merge 5 commits intomainfrom
feature/#101/wind-angle
Open

Enable retrieving and overriding wind attack angle#114
ai-qui wants to merge 5 commits intomainfrom
feature/#101/wind-angle

Conversation

@ai-qui
Copy link
Member

@ai-qui ai-qui commented Feb 25, 2026

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

fixes #101

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The breaking change or deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Following parameters and attributes are renamed to better reflect what their signification:
azimuth -> cable_azimuth
wind_angle -> wind_azimuth
attack_angle -> wind_attack_angle

The parameters' order used to instantiate ConvectiveCooling has been changed and a new optional parameter wind_attack_angle has been added. Parameter wind_azimuth is now optional. Please adapt your code if you use positional argument. No changes are required if you use keyword arguments.

For cigre model:

# Before
ConvectiveCooling(
    altitude,
    azimuth,
    ambient_temperature,
    wind_speed,
    wind_angle,
    outer_diameter,
    roughness_ratio,
    g,
    ...
)

# After
ConvectiveCooling(
    altitude,
    cable_azimuth,
    ambient_temperature,
    wind_speed,
    outer_diameter,
    roughness_ratio,
    wind_azimuth,
    wind_attack_angle,
    g,
    ...
)

For IEEE, olla and RTE models:

# Before
ConvectiveCooling(
    altitude,
    azimuth,
    ambient_temperature,
    wind_speed,
    wind_angle,
    outer_diameter,
    ...
)

# After
ConvectiveCooling(
    altitude,
    cable_azimuth,
    ambient_temperature,
    wind_speed,
    outer_diameter,
    wind_azimuth,
    wind_attack_angle,
    ...
)

Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
@ai-qui ai-qui force-pushed the feature/#101/wind-angle branch from 70405c5 to 47a6849 Compare February 25, 2026 10:39
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
64.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ai-qui
Copy link
Member Author

ai-qui commented Feb 25, 2026

SonarCloud analysis fails because all the code where parameters/variables have been renamed is considered "new" and sonar complains about insufficient test coverage. I suggest bypassing the condition on new code test coverage for this PR since adding tests isn't in this PR's scope.

@ai-qui ai-qui changed the title Feature/#101/wind angle Enable retrieving and overriding wind attack angle Feb 25, 2026
@ai-qui
Copy link
Member Author

ai-qui commented Feb 26, 2026

TODO: test that attack angle is always between 0 and 90°

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retrieve and override wind incidence angle on the conductor

1 participant