Enable retrieving and overriding wind attack angle#114
Open
Conversation
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
70405c5 to
47a6849
Compare
|
Member
Author
|
SonarCloud analysis fails because all the code where parameters/variables have been renamed is considered "new" and sonar complains about insufficient test coverage. I suggest bypassing the condition on new code test coverage for this PR since adding tests isn't in this PR's scope. |
Member
Author
|
TODO: test that attack angle is always between 0 and 90° |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
fixes #101
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Following parameters and attributes are renamed to better reflect what their signification:
azimuth -> cable_azimuth
wind_angle -> wind_azimuth
attack_angle -> wind_attack_angle
The parameters' order used to instantiate
ConvectiveCoolinghas been changed and a new optional parameterwind_attack_anglehas been added. Parameterwind_azimuthis now optional. Please adapt your code if you use positional argument. No changes are required if you use keyword arguments.For cigre model:
For IEEE, olla and RTE models: