Rename precomputed_solar_radiation into measured_solar_irradiance#118
Open
Rename precomputed_solar_radiation into measured_solar_irradiance#118
Conversation
…radiance Also, fix handling of the case when measured_solar_irradiance is unknown, for all models but RTE. /!\ measured_solar_irradiance is now a required parameter of SolarHeating for all models but RTE. Signed-off-by: ai-qui <184963772+ai-qui@users.noreply.github.com>
jeremy-vernay
force-pushed
the
feature/#115/rename_solar_radiation
branch
from
4981150 to
08a6b47
Compare
|
| for heat_equation in [ | ||
| HeatEquationType.WITH_ONE_TEMPERATURE, | ||
| HeatEquationType.WITH_THREE_TEMPERATURES, | ||
| # HeatEquationType.WITH_THREE_TEMPERATURES, |
Contributor
There was a problem hiding this comment.
je pense que tu veux décommenter ces lignes.
jeremy-vernay
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, fix handling of the case when measured_solar_irradiance
unknown, for all models but RTE.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
cf. #115
Does this PR introduce a breaking change or deprecate an API?
What changes might users need to make in their application due to this PR? (migration steps)
measured_solar_irradianceis now a required parameter ofSolarHeatingfor all models but RTE. Set it tonp.nanif unknown.Other information: