Update README.md - install command#94
Open
mdtameemkhan wants to merge 1 commit intophoenixbyrd:mainfrom
Open
Conversation
Updated install command to fix rm install_xfce_native.sh command in script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated install command to fix error on
rm install_xfce_native.shin scriptWhat happens is, the current install command saves the files as
install.sh, but the script itself expects it to be saved with original name, and tries to delete itself withrm install_xfce_native.shonce everything is done.This results in a error upon the completion of script.
This PR updates the installation command, saving the file with original name and let the script delete itself after things are complete, as expected.