retrieve n addresses starting from next unused index #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sign/verify messages using bitcoin-js + unit tests
tanx
requested changes
Sep 22, 2022
Member
tanx
left a comment
tanx
left a comment
There was a problem hiding this comment.
Made one comment. Also looks like the package-lock.json is conflicting after merging the other PR to the master.
| return nextFreeAddresses; | ||
| } | ||
| // return object: [{ index: "", address: ""}, ...] | ||
|
|
Member
There was a problem hiding this comment.
How is this different from async getAddressAsync() right above it?
Contributor
Author
There was a problem hiding this comment.
This function returns n addresses starting from the next unused address retrieved by getAddressAsync(). I suppose the looping could just happen on the app side but I think it's a useful minor addition to the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.