Allows to pass config name to search class configuration#2
Closed
Allows to pass config name to search class configuration#2
Conversation
4978555 to
1336bf0
Compare
Pull Request Test Coverage Report for Build 9398386413Details
💛 - Coveralls |
Collaborator
Author
|
Superseeded by #4 |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates search-related functions and the
SearchCriterionobject to receive a new configuration parameter:config_name. By default, we use the PostgreSQL default text search config,pg_catalog.simple.Motivation and Context
When using PostgreSQL search, the user might need to change the default configuration. This PR makes it possible by allowing the user to specify which config he/she wants to use. For example, using the PostgreSQL extension
unaccent, we can now query as:Tortoise will generate the below SQL query
'SELECT "id", "name" FROM "cities" WHERE TO_TSVECTOR(\'public.unaccent\',"name") @@ TO_TSQUERY(\'public.unaccent\',\'paris\')'Because of the current implementation of the
__searchfilter, inside theSearchCriterion.__init__, we extract theconfig_namefrom the function in use, in the above exampleToTsQuery, to pass it to theToTsVectorfunction.How Has This Been Tested?
Checklist: