Add PHPUnit 12 support and fix test compatibility issues#26
Merged
CodeWithKyrian merged 2 commits intophp-mcp:mainfrom Jul 1, 2025
Merged
Add PHPUnit 12 support and fix test compatibility issues#26CodeWithKyrian merged 2 commits intophp-mcp:mainfrom
CodeWithKyrian merged 2 commits intophp-mcp:mainfrom
Conversation
- Changed assertions in ManualRegistrationTest to verify handler as an array containing the handler class and method instead of separate properties. - Updated tests to reflect the new structure for handler registration, ensuring consistency across tool, resource, and prompt registrations.
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for PHPUnit 12 and fixes test compatibility issues that arose from updates to the underlying
php-mcp/serverpackage.Changes Made
1. PHPUnit Version Support
composer.jsonto support PHPUnit 12 alongside existing versions 10 and 11^10.0 || ^11.0to^10.0 || ^11.0 || ^12.02. Test Fixes
ManualRegistrationTest.phpthat were caused by API changes inphp-mcp/serverv3.2.1handlerproperty instead of deprecatedhandlerClassandhandlerMethodpropertieshandlerproperty that can contain:[ClassName::class, 'methodName']for class methodsClassName::classfor invokable classesTesting
Motivation
This update ensures the package works with the latest PHPUnit version and remains compatible with recent updates to the
php-mcp/serverdependency.