Skip to content

Use ull integer suffix for bitwise logic #19673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

Use ull integer suffix for bitwise logic #19673

merged 1 commit into from
Sep 3, 2025
+2 −2

Conversation

iluuu1994
Copy link
Member

If (brake->type+1) exeeds 30, we have undefined behavior and won't actually remove the relevant bit.

See GH-19633

@iluuu1994
Use ull integer suffix for bitwise logic
91bcd54 
If (brake->type+1) exeeds 30, we have undefined behavior and won't actually
remove the relevant bit.

See phpGH-19633
edorian
edorian approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@edorian edorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM approval, no technical review performed.

@iluuu1994 iluuu1994 merged commit 8a4cbde into php:master Sep 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorian edorian edorian approved these changes

Assignees
No one assigned
Labels
SAPI: phpdbg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @edorian