Skip to content

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Sep 2, 2025

We must take into account the calling convention of the tailcall vm.

We must take into account the calling convention of the tailcall vm.
Copy link
Member

@arnaud-lb arnaud-lb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@arnaud-lb
Copy link
Member

Oh, however, opline->handler will not return immediately - it calls the next handler instead, so it will bypass the step limit.

I suggest to fetch the stepping-friendly handler func with zend_get_opcode_handler_func(), like in https://github.com/arnaud-lb/php-src/blob/73b98a385848f4800cf81392b09d648e8cd5a698/ext/opcache/jit/zend_jit_trace.c#L8921.

@nielsdos
Copy link
Member Author

nielsdos commented Sep 3, 2025

Okay done that now, but I wonder how expensive the hash+array lookup is :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants