Fix GH-19942: avoid infinite loop when using iterator_count() on an empty SplFileObject #19957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
inf-loop-it-splfileobj
branch
from
5d86b6c to
eaec347
Compare
|
Will this break for non-seekable file streams? |
alexandre-daubois
force-pushed
the
inf-loop-it-splfileobj
branch
from
eaec347 to
c80b777
Compare
|
Good catch, I added checks to only perform this on seekable streams + a test to cover it. |
…n empty SplFileObject
alexandre-daubois
force-pushed
the
inf-loop-it-splfileobj
branch
from
c80b777 to
4b81bba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.