Skip to content

Conversation

manuelm
Copy link
Contributor

@manuelm manuelm commented Sep 25, 2025

This fixes two separate cases of ini values not getting restored:

  • The max_memory_limit handler directly overwrites the global memory_limit value.
  • The fpm sapi does not restore any ini values passed through fcgi environment (PHP_VALUE header).

Both cases should be passed through zend_alter_ini, so modified_ini_directives can keep track.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OnChangeMaxMemoryLimit part makes sense to me. I did not know per-host ini settings were a thing, and could change OnChangeMaxMemoryLimit after OnChangeMemoryLimit.

As for the FPM part, I'll let that review up to Jakub, as I don't know much about FPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants