Skip to content

pg_fetch_object() with abstract classes #20180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 4, 2025
Merged

pg_fetch_object() with abstract classes #20180

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9274675
ext/pgsql: Fix segfaults when attemting to fetch row into a non-insta…
Girgias Oct 15, 2025
c48266c
address review
Girgias Oct 21, 2025
cfe422c
shutup clean?
Girgias Oct 22, 2025
72d8f90
move clean for windows debugging
Girgias Oct 22, 2025
543467e
Don't output anything from config
ndossche Oct 22, 2025
a88bf91
Revert "move clean for windows debugging"
ndossche Oct 22, 2025
904bc33
restrict ci for debugging
ndossche Oct 22, 2025
9a149a7
Fix CI
ndossche Oct 26, 2025
0dee809
Remove workflow changes
Girgias Nov 3, 2025
931a94d
Run all tests on Windows
Girgias Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/pgsql/tests/pg_fetch_object_with_abstract_class.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ try {
--CLEAN--
<?php
include('config.inc');
$db = pg_connect($conn_str);
pg_query($db, "DROP TABLE IF EXISTS pg_fetch_object_abstract_class cascade");
$db = @pg_connect($conn_str);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue really weirds me out. would it be possible to do the cleaning somewhere in the file section instead just for testing once at least ?

@pg_query($db, "DROP TABLE IF EXISTS pg_fetch_object_abstract_class cascade");
?>
--EXPECT--
Error: Cannot instantiate interface I
Expand Down
Loading