Add ability to embed resources internally, without loading from urls.#25
Open
ttodua wants to merge 9 commits intophpLiteAdmin:masterfrom
Open
Add ability to embed resources internally, without loading from urls.#25ttodua wants to merge 9 commits intophpLiteAdmin:masterfrom
ttodua wants to merge 9 commits intophpLiteAdmin:masterfrom
Conversation
Update phpliteadmin.config.sample.php
Author
|
@DeyV @AndiKod @Dygear @dreadnaut Any of you with merging capabilities? Would have been nice if this PR was reviewed. |
|
I'm not officially part of the team but I'll have a look tomorrow. |
|
This looks good to me. Nice job on the etag implementation, it's very straight forward. |
|
Are you guys still active in the project? I know source control is actually handled on bitbucket, but even there there is very little movement. |
Contributor
|
Hello there 👋 I was only briefly helping with the project, and while I still keep an eye on it, I have no part or say in the development at this point. Sorry I can't be of help 🙇 |
|
I will put a thing on the bitbucket and see if it's still active over there. If not, I'll let this sit for 30 days and I may take it over if no one objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve #24 without any conflict with existing users & codebase.