-
Notifications
You must be signed in to change notification settings - Fork 9
fix: update phpactor package to 2025-07-25.0 #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update phpactor package to 2025-07-25.0 #205
Conversation
update phpactor/phpactor package to 2025.07.25.0
|
Guys, can this happen automatically? |
|
The release was here https://github.com/phpactor/vscode-phpactor/releases/tag/1.7.3 Do you use composer.json ? Phpactor didn't work very well from composer.json I can try to get dependabot to update this file too. |
I don't use composer on all of my projects. And on the projects that I do use, it's not a good idea to install this package |
|
@zobo How do I install a phar file inside the extension? |
|
Hi, sorry I missed your response. While the extension is built, the latest phpactor phar is downloaded (see https://github.com/phpactor/vscode-phpactor/blob/4e42ce6d8592cb91a208ebe4d8e4ce8e079e9aee/package.json#L21C10-L21C26) and then packed into the final vsix. |
|
in theory, it also uses the old installation from this folder ~/.vscode-server/extensions/phpactor.vscode-phpactor-1.7.3/vendor/phpactor/phpactor/bin/. parameter from config used version in extension 2025.04.17.0 so far, I'm using my own version with installation via postCreateCommand in devcontainer. |
|
I went back and looked at this and indeed the extension uses the vendorized phpactor and not phar. I have to recheck this as I've clearly forgotten what I did... |
|
I needed GPT to point out the problem why renovate didn't update the version. It's name is |
|
Thx 😊 |
update phpactor/phpactor package to 2025.07.25.0