Skip to content

Conversation

@ashishpatel1992
Copy link

CANNOT_MERGE_SAME duplicate entry removed

CANNOT_MERGE_SAME duplicate entry removed
@rmcgirr83
Copy link
Contributor

The purpose of that lang entry is in case an admin tries to merge the same user (same user id). Nothing to do with trying to merge himself. It is not a duplicate entry in the lang file.

@ashishpatel1992
Copy link
Author

For both of them keys are same, they should have different keys for different text.

'CANNOT_MERGE_SAME'			=> 'You can’t merge and delete the same user.',
'CANNOT_MERGE_SAME'			=> 'You cannot merge the user account <strong>%s</strong> with itself.',

@rmcgirr83
Copy link
Contributor

rmcgirr83 commented Jun 4, 2020

Please look again. They are not the same keys.

@ashishpatel1992
Copy link
Author

See this

image

@rmcgirr83
Copy link
Contributor

I missed that one and you are quite right. I don't have access to the repo on here anymore to make the merge of your commit.

@ashishpatel1992
Copy link
Author

@rmcgirr83 I think someone from phpbbmodders would accept this merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants