-
Notifications
You must be signed in to change notification settings - Fork 66
Add support for psalm-inheritors
and phpstan-sealed
tag
#273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I’d prefer a different name for the PHPStan tag. some keywords to consider:
What are your suggestions? |
I checked all the possibility and psalm supports them
Since it works for So I would say something like
But if we look at other languages (and the related php rfc https://wiki.php.net/rfc/sealed_classes), seems adding a
Therefor maybe something like Or Does anything satisfy you @ondrejmirtes ? |
|
Of course Phpstan should understand psalm inheritors too. |
psalm-inheritors
and phpstan-inheritors
tagpsalm-inheritors
and phpstan-sealed
tag
Done with |
The
is failing because of php deprecation on PHPUnit 10.5.11. The dev-dependency was bumped on slevomat coding standard in commit 4747e312a24d4827b1d090b5908c7d5b16cf0580 |
@VincentLanglet Yes, in a separate PR please. |
Thank you! Please send a PR to phpstan-src as well. |
Needed to implements the following feature on phpstan side
https://psalm.dev/docs/annotating_code/supported_annotations/#psalm-inheritors