Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 29, 2025

  • removes no longer necessary return types
  • fix wrongly named args in dataproviders

=> fixes required for a later PHPUnit 10 upgrade

@staabm staabm marked this pull request as ready for review October 29, 2025 09:40
'pdoPgsqlResult' => -1,
'pgsqlResult' => -1,
'mssqlResult' => -1,
'dqlTemplate' => 'SELECT -1 FROM %s t',
Copy link
Contributor Author

@staabm staabm Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the error which got triggered by the wrong arg names should be made phpunit11+ only

Error: Missing parameter $dqlTemplate (string) in call to method PHPStan\Platform\QueryResultTypeWalkerFetchTypeMatrixTest::testPdoMysqlDefault().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, these error only showed up, as the phpstan-phpunit in the builds did not yet include the phpstan/phpstan-phpunit@033f690 commit.

all good than

@ondrejmirtes ondrejmirtes merged commit 197d47c into phpstan:2.0.x Oct 29, 2025
39 of 40 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the unit branch October 29, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants