add tests for phpunit9

Author: staabm

tests/Rules/PHPUnit/DataProviderDataRuleTest.php

@@ -14,6 +14,7 @@
  */
 class DataProviderDataRuleTest extends RuleTestCase
 {
+	private ?int $phpunitVersion;
 
 	protected function getRule(): Rule
 	{
@@ -24,13 +25,13 @@ protected function getRule(): Rule
 			new DataProviderDataRule(
 				new TestMethodsHelper(
 					self::getContainer()->getByType(FileTypeMapper::class),
-					new PHPUnitVersion(10)
+					new PHPUnitVersion($this->phpunitVersion)
 				),
 				new DataProviderHelper(
 					$reflectionProvider,
 					self::getContainer()->getByType(FileTypeMapper::class),
 					self::getContainer()->getService('defaultAnalysisParser'),
-					new PHPUnitVersion(10)
+					new PHPUnitVersion($this->phpunitVersion)
 				),
 
 			),
@@ -42,6 +43,8 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
+		$this->phpunitVersion = 10;
+
 		$this->analyse([__DIR__ . '/data/data-provider-data.php'], [
 			[
 				'Parameter #2 $input of method DataProviderDataTest\FooTest::testWithAttribute() expects string, int given.',
@@ -176,6 +179,8 @@ public function testRulePhp8(): void
 			self::markTestSkipped();
 		}
 
+		$this->phpunitVersion = 10;
+
 		$this->analyse([__DIR__ . '/data/data-provider-data-named.php'], [
 			[
 				'Parameter $input of method DataProviderDataTestPhp8\NamedArgsInProvider::testFoo() expects string, int given.',
@@ -203,6 +208,8 @@ public function testRulePhp8(): void
 
 	public function testVariadicMethod(): void
 	{
+		$this->phpunitVersion = 10;
+
 		$this->analyse([__DIR__ . '/data/data-provider-variadic-method.php'], [
 			[
 				'Method DataProviderVariadicMethod\FooTest::testProvide2() invoked with 1 parameter, at least 2 required.',
@@ -241,6 +248,8 @@ public function testVariadicMethod(): void
 
 	public function testTrimmingArgs(): void
 	{
+		$this->phpunitVersion = 10;
+
 		$this->analyse([__DIR__ . '/data/data-provider-trimming-args.php'], [
 			[
 				'Method DataProviderTrimmingArgs\FooTest::testProvide() invoked with 2 parameters, 1 required.',

tests/Rules/PHPUnit/DataProviderDeclarationRuleTest.php

@@ -11,6 +11,7 @@
  */
 class DataProviderDeclarationRuleTest extends RuleTestCase
 {
+	private ?int $phpunitVersion;
 
 	protected function getRule(): Rule
 	{
@@ -21,7 +22,7 @@ protected function getRule(): Rule
 				$reflection,
 				self::getContainer()->getByType(FileTypeMapper::class),
 				self::getContainer()->getService('defaultAnalysisParser'),
-				new PHPUnitVersion(10)
+				new PHPUnitVersion($this->phpunitVersion)
 			),
 			true,
 			true
@@ -30,6 +31,8 @@ protected function getRule(): Rule
 
 	public function testRule(): void
 	{
+		$this->phpunitVersion = 10;
+
 		$this->analyse([__DIR__ . '/data/data-provider-declaration.php'], [
 			[
 				'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
@@ -70,8 +73,34 @@ public function testRule(): void
 		]);
 	}
 
+	public function testRulePhpUnit9(): void
+	{
+		$this->phpunitVersion = 9;
+
+		$this->analyse([__DIR__ . '/data/data-provider-declaration.php'], [
+			[
+				'@dataProvider providebaz related method is used with incorrect case: provideBaz.',
+				16,
+			],
+			[
+				'@dataProvider provideQuux related method must be public.',
+				16,
+			],
+			[
+				'@dataProvider provideNonExisting related method not found.',
+				70,
+			],
+			[
+				'@dataProvider NonExisting::provideNonExisting related class not found.',
+				70,
+			],
+		]);
+	}
+
 	public function testFixDataProviderStatic(): void
 	{
+		$this->phpunitVersion = 10;
+
 		$this->fix(__DIR__ . '/data/data-provider-static-fix.php', __DIR__ . '/data/data-provider-static-fix.php.fixed');
 	}