Assert*Rules: Do cheap checks first #247
Merged
+29
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 27, 2025
|
|
||
| public function processNode(Node $node, Scope $scope): array | ||
| { | ||
| if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) { |
Contributor
Author
There was a problem hiding this comment.
before this PR, any CallLike triggered autoloading of the PHPUnit classes via reflection (no matter whether it actually contained the assert prefix in the method name or no matter whether the CallLike was related to PHPUnit at all)
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shuffling the initial if-checks so the cheapest ones get called first.
AssertRuleHelper::isMethodOrStaticCallOnAssertinternally usesnew ObjectType('PHPUnit\Framework\Assert')which triggers reflection logic and file parsingsee
refs phpstan/build-infection#16