Skip to content

add Type::isError method #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.1.x
Choose a base branch
from
Open

add Type::isError method #4530

wants to merge 4 commits into from
+313 −203

Conversation

@canvural
Copy link
Contributor

@canvural canvural commented Nov 6, 2025

This one does not add too much value, but I just didn't want to do instanceof ErrorType in my extensions 😄

ondrejmirtes
ondrejmirtes requested changes Nov 6, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApiInstanceofTypeRule should be made aware of this 😊

@canvural canvural force-pushed the is-error branch 2 times, most recently from b940dc5 to e8922d3 Compare November 6, 2025 16:23
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 7, 2025

Do you also feel like doing isNever() + isExplicitNever()? :)

@canvural
Copy link
Contributor Author

canvural commented Nov 7, 2025

Do you also feel like doing isNever() + isExplicitNever()? :)

Didn't ever need that I guess, but sure I can. In a separate PR?

@canvural
Copy link
Contributor Author

canvural commented Nov 10, 2025 •
edited
Loading

The mutations look valid, but I don't know how I can change them in bulk.

Edit: I guess $type instanceof ErrorType could be !$type->isError()->no() and !$type instanceof ErrorType can be $type->isError()->no() ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@canvural @ondrejmirtes