Change the verify mode to VERIFY_PEER#4
Open
fillyfuxilly wants to merge 4 commits intophuesler:masterfrom
Open
Change the verify mode to VERIFY_PEER#4fillyfuxilly wants to merge 4 commits intophuesler:masterfrom
fillyfuxilly wants to merge 4 commits intophuesler:masterfrom
Conversation
added 2 commits
April 16, 2020 10:27
This at least declines self-signed certificates and certificates for a wrong host.
With versions 1.9.3 to 2.1.0 it won't find the method 'last_comment' and version 2.1.2 is not supported by Ubuntu 16.04.6 that Travis currently uses for this project.
fillyfuxilly
changed the title
added 2 commits
April 16, 2020 12:29
Remove v2.1.2, because it doesn't get supported. Run travis with newer versions instead.
fillyfuxilly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This at least declines self-signed certificates and certificates for a wrong host. With this we add some security against man in the middle attacks.
Edit: The build failed because of the ruby versions
Travis changed the Ubuntu version and with it the ruby versions it supports. The versions 1.9.3 to 2.1.0 fail because they are only compatible with rake <11. Version 2.1.2 is not supported at all anymore.
I tested if a "newer" version(2.1.5) would work, but it also has trouble with the rake version, so I will try to set the rake version to be < 11.
Edit 2: Solution
It works with specifying a rake version <11, but the ruby version 2.1.2 still doesn't get supported by Travis' current Ubuntu version. See this list.
Replacing it with newer versions probably makes sense.